impr: Improve orbit camera to better behave on mouse scroll-wheel#2304
Merged
iwoplaza merged 1 commit intosoftware-mansion:releasefrom Apr 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the docs examples’ orbit camera zoom behavior to be more consistent between touchpads and mouse wheels by normalizing wheel deltas and limiting extreme per-event zoom steps.
Changes:
- Normalize
WheelEvent.deltaYbased onevent.deltaMode(line/page → pixel-equivalent). - Clamp the normalized wheel delta magnitude to reduce large discrete mouse-wheel notch jumps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Normalize WheelEvent.deltaY based on deltaMode before passing to zoomCamera. Mouse wheel events use DOM_DELTA_LINE mode (Firefox) or report large pixel values (~100 per notch in Chrome), while touchpad events report small pixel values (~1-5). Without normalization, mouse wheel zoom jumps are ~20x larger than intended. The delta is also clamped to 60 to prevent large discrete jumps regardless of input device or browser behavior. Fixes software-mansion#2160
iwoplaza
force-pushed
the
impr/orbit-camera-scroll-wheel
branch
from
98b254c to
7e32607
Compare
iwoplaza
approved these changes
Apr 12, 2026
Collaborator
iwoplaza
left a comment
iwoplaza
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes
WheelEvent.deltaYbased ondeltaModein the orbit camera'swheel event handler. Mouse scroll-wheel events report values ~20x larger
than touchpad events (Chrome: ~100px per notch in pixel mode; Firefox: ~3
in line mode), making zoom extremely jumpy with a mouse.
Changes
apps/typegpu-docs/src/examples/common/setup-orbit-camera.tsevent.deltaModeand convert line/page deltas to pixel equivalentsmouse wheel notches (Chrome reports
deltaMode=0butdeltaY=100)The touchpad experience is unchanged since touchpad events already use
pixel mode with small delta values (1-5).
Reference: WheelEvent.deltaMode
Fixes #2160
This contribution was developed with AI assistance (Claude Code).